Skip to content

Fix editor not updating titlebar with new difficulty name after rename #36908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdach merged 1 commit into from
Mar 10, 2026
Merged

Fix editor not updating titlebar with new difficulty name after rename #36908

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions osu.Game/Screens/Edit/Editor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,15 +188,14 @@ public bool ReadyForUse

private bool isNewBeatmap;

protected override UserActivity InitialActivity
protected override UserActivity InitialActivity => getCurrentUserActivity();

private UserActivity getCurrentUserActivity()
{
get
{
if (Beatmap.Value.Metadata.Author.OnlineID == api.LocalUser.Value.OnlineID)
return new UserActivity.EditingBeatmap(Beatmap.Value.BeatmapInfo);
if (Beatmap.Value.Metadata.Author.OnlineID == api.LocalUser.Value.OnlineID)
return new UserActivity.EditingBeatmap(Beatmap.Value.BeatmapInfo);

return new UserActivity.ModdingBeatmap(Beatmap.Value.BeatmapInfo);
}
return new UserActivity.ModdingBeatmap(Beatmap.Value.BeatmapInfo);
}

protected override bool InitialBackButtonVisibility => false;
Expand Down Expand Up @@ -604,6 +603,9 @@ internal bool Save()
updateLastSavedHash();
onScreenDisplay?.Display(new BeatmapEditorToast(ToastStrings.BeatmapSaved, editorBeatmap.BeatmapInfo.GetDisplayTitle()));
Saved?.Invoke();

// This triggers an update to the window title post-save (ie if the difficulty name changed).
Activity.Value = getCurrentUserActivity();
return true;
}

Expand Down
Loading