Preserve bookmarks when creating a new difficulty from scratch#36675
Merged
peppy merged 4 commits intoppy:masterfrom Feb 16, 2026
Merged
Preserve bookmarks when creating a new difficulty from scratch#36675peppy merged 4 commits intoppy:masterfrom
peppy merged 4 commits intoppy:masterfrom
Conversation
…ficulty from scratch
To follow the style of other assertions
peppy
approved these changes
Feb 16, 2026
This was referenced Mar 3, 2026
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33395
Copies the bookmarks from
referenceWorkingBeatmapwhile creating a new difficulty from scratch. I adapted the tests inTestSceneEditorBeatmapCreationto include the bookmark checks.