Add user role to MultiplayerRoomUser#36652
Merged
peppy merged 1 commit intoppy:masterfrom Feb 11, 2026
Merged
Conversation
Adding this field to this model has several vague reasons that I can't fully formulate yet, but I can't see myself going forward *without* this. - People were very excited about having referees displayed on the room participants' list, and so adding the referees as real `MultiplayerRoomUser`s helps this. Having the role could even be used client-side to show a special icon or other status on the participants list. (Which isn't done yet, could be as an aesthetic follow-up after the basics are in place.) - Server-side, having this field is convenient for things like permission checks or just plain logic, as with two hubs you just need to do different *stuff* on a `MultiplayerRoomUser`.
1 task
peppy
approved these changes
Feb 11, 2026
github-project-automation
bot
moved this from Pending Review
to Done
in osu! team task tracker
Member
|
@bdach i made |
Collaborator
Author
|
I don't think this change is in that tag... 
|
Member
|
Okay, let's try |
This was referenced Mar 3, 2026
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding this field to this model has several vague reasons that I can't fully formulate yet, but I can't really see myself going forward without this.
MultiplayerRoomUsers helps this. Having the role could even be used client-side to show a special icon or other status on the participants list. (Which isn't done yet, could be as an aesthetic follow-up after the basics are in place.)MultiplayerRoomUser.