Fix local beatmap metadata not being cleared when previously selected beatmap is online#36632
Merged
peppy merged 3 commits intoppy:masterfrom Feb 9, 2026
Merged
Conversation
peppy
approved these changes
Feb 9, 2026
| AddUntilStep("rating wedge hidden", () => !wedge.RatingsVisible); | ||
| AddUntilStep("fail time wedge hidden", () => !wedge.FailRetryVisible); | ||
|
|
||
| // just check for text everywhere on the wedge as the classes are private and generic |
Member
There was a problem hiding this comment.
bit dodge but worst case it'll yell at us so 🤷
minetoblend
pushed a commit
to minetoblend/osu
that referenced
this pull request
Feb 9, 2026
…d beatmap is online (ppy#36632) - Closes ppy#36584 The last two commits could be either fixes to the issue above, but in a code quality perspective, the scheduler in `setLink()` seems unnecessary as the other set methods don't have it (other than making it run last) and the other commit is self explanatory.
This was referenced Feb 9, 2026
This was referenced Mar 3, 2026
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last two commits could be either fixes to the issue above, but in a code quality perspective, the scheduler in
setLink()seems unnecessary as the other set methods don't have it (other than making it run last) and the other commit is self explanatory.