Fix star rating no longer updating from mod setting changes after re-entering song select#36601
Merged
peppy merged 2 commits intoppy:masterfrom Feb 6, 2026
Conversation
…entering song select As "reported" in https://osu.ppy.sh/comments/3929603. On one hand, this *is* firmly a second-order failure stemming from all the stupid games we're playing by making mod select overlay instances always own the game-global references to mods, but on the other hand, isn't `IEquatable` and its silent pervasive nature just *awesome* to deal with sometimes?
peppy
approved these changes
Feb 6, 2026
github-project-automation
bot
moved this from Pending Review
to Done
in osu! team task tracker
minetoblend
pushed a commit
to minetoblend/osu
that referenced
this pull request
Feb 9, 2026
…entering song select (ppy#36601)
This was referenced Feb 9, 2026
This was referenced Mar 3, 2026
This was referenced Mar 16, 2026
This was referenced Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As "reported" in https://osu.ppy.sh/comments/3929603.
On one hand, this is firmly a second-order failure stemming from all the stupid games we're playing by making mod select overlay instances always own the game-global references to mods, but on the other hand, isn't
IEquatableand its silent pervasive nature just awesome to deal with sometimes?