Improve handling of account registration errors#36600
Merged
peppy merged 2 commits intoppy:masterfrom Feb 8, 2026
Merged
Conversation
The lack of it meant that in specific scenarios web would respond with a chunk of HTML instead of JSON.
There are scenarios where this can happen, and if it did, previously the strict requirement to have both would cause the specific message to be discarded and replaced with the generic "something happened" one.
bdach
added
the
area:online functionality
peppy
approved these changes
Feb 8, 2026
| AddParameter(@"user[user_email]", Email); | ||
| AddParameter(@"user[password]", Password); | ||
|
|
||
| AddHeader(@"Accept", @"application/json"); |
Member
There was a problem hiding this comment.
Do wonder if we should specify this in the base class 🤷
Collaborator
Author
There was a problem hiding this comment.
If the base class was OsuJsonWebRequest, it would already have been specified. But this isn't that, because of reasons I'm uncertain of at this time but suspect to be related to passing params in query rather than body as json.
github-project-automation
bot
moved this from Pending Review
to Done
in osu! team task tracker
minetoblend
pushed a commit
to minetoblend/osu
that referenced
this pull request
Feb 9, 2026
## [Specify `Accept` header in registration request](ppy@28edb78) The lack of it meant that in specific scenarios web would respond with a chunk of HTML instead of JSON. ## [Allow showing registration error message even if no redirect is given](ppy@6ad4994) There are scenarios where this can happen, and if it did, previously the strict requirement to have both would cause the specific message to be discarded and replaced with the generic "something happened" one.
This was referenced Feb 9, 2026
This was referenced Mar 3, 2026
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specify
Acceptheader in registration requestThe lack of it meant that in specific scenarios web would respond with a chunk of HTML instead of JSON.
Allow showing registration error message even if no redirect is given
There are scenarios where this can happen, and if it did, previously the strict requirement to have both would cause the specific message to be discarded and replaced with the generic "something happened" one.