Allow binding left/right modifier keys separately for gameplay bindings#36585
Merged
peppy merged 6 commits intoppy:masterfrom Feb 9, 2026
Merged
Conversation
Collaborator
|
I dunno about this. I could maybe get behind distinguishing left and right modifiers when modifying ruleset keybindings specifically but not like this. Not sure. Would need more @ppy/team-client opinions. |
Member
|
I agree it makes sense specifically for game bindings, but not for global bindings. @failaip12 Are you willing to attempt to make it isolated to only ruleset key bindings? |
Contributor
Author
|
I will try to do that, should i do it on this PR, or open a new one? |
Collaborator
|
You can push to this one or open a new one, no real preference. Worst case scenario we'll just squash merge this one. |
peppy
changed the title
peppy
approved these changes
Feb 9, 2026
This was referenced Feb 9, 2026
This was referenced Feb 13, 2026
This was referenced Feb 13, 2026
This was referenced Mar 3, 2026
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #36583.