Fix FormCheckbox playing sounds twice#36504
Merged
bdach merged 1 commit intoppy:masterfrom Jan 28, 2026
Merged
Conversation
This removes the disabled sound, but I think that's fine. If we want that, it should be handled by `HoverClickSounds` (which I'm currently intentionally not using because it can be a bit noisy). Closes ppy#36503.
This comment was marked as off-topic.
This comment was marked as off-topic.
Member
Author
|
@diquoks please stay out of PRs. we don't need dialogue here. thanks. |
bdach
approved these changes
Jan 28, 2026
This was referenced Feb 9, 2026
This was referenced Mar 3, 2026
This was referenced Mar 16, 2026
This was referenced Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the disabled sound, but I think that's fine. If we want
that, it should be handled by
HoverClickSounds(which I'm currentlyintentionally not using because it can be a bit noisy).
Closes #36503.