Skip to content

Add server-side models for ranked play#36498

Merged
bdach merged 6 commits intoppy:masterfrom
smoogipoo:ranked-play-models
Jan 28, 2026
Merged

Add server-side models for ranked play#36498
bdach merged 6 commits intoppy:masterfrom
smoogipoo:ranked-play-models

Conversation

@smoogipoo
Copy link
Copy Markdown
Contributor

Old Server New Server
Old Client 🟢 🟢
New Client 🔴 🟢

The most important change here that contributes to the above crosstable, is that I've renamed GetMatchmakingPools() to GetMatchmakingPoolsOfType(). This is for two reasons:

  1. To add the pool type parameter.
  2. Because SignalR does not support method overloads.

The idea here is the server can add a GetMatchmakingPools() (old name) method, redirect it to the QuickPlay type, and old clients will continue behaving correctly.

/// <summary>
/// Matchmaking: Quick play
/// </summary>
Matchmaking,
Copy link
Copy Markdown
Contributor Author

@smoogipoo smoogipoo Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I'm using "matchmaking" to refer to quick play. I'm hoping to do a whole codebase refactor at some point to fix namespace/class namings, but this particular member is a different beast because it is a databased value.

@peppy peppy moved this from Inbox to Pending Review in osu! team task tracker Jan 28, 2026
Copy link
Copy Markdown
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loose thoughts about possible representation issues, no follow-up expected on any of these

@bdach
Copy link
Copy Markdown
Collaborator

bdach commented Jan 28, 2026

@peppy not sure if you want to go over this

@peppy
Copy link
Copy Markdown
Member

peppy commented Jan 28, 2026

@bdach happy to leave in your hands 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants