Add server-side models for ranked play#36498
Merged
bdach merged 6 commits intoppy:masterfrom Jan 28, 2026
Merged
Conversation
1 task
smoogipoo
commented
Jan 28, 2026
| /// <summary> | ||
| /// Matchmaking: Quick play | ||
| /// </summary> | ||
| Matchmaking, |
Contributor
Author
There was a problem hiding this comment.
In general, I'm using "matchmaking" to refer to quick play. I'm hoping to do a whole codebase refactor at some point to fix namespace/class namings, but this particular member is a different beast because it is a databased value.
bdach
reviewed
Jan 28, 2026
Collaborator
bdach
left a comment
There was a problem hiding this comment.
loose thoughts about possible representation issues, no follow-up expected on any of these
osu.Game/Online/Multiplayer/MatchTypes/RankedPlay/RankedPlayRoomState.cs
Outdated
Show resolved
Hide resolved
osu.Game/Online/Multiplayer/MatchTypes/RankedPlay/RankedPlayRoomState.cs
Outdated
Show resolved
Hide resolved
bdach
approved these changes
Jan 28, 2026
Collaborator
|
@peppy not sure if you want to go over this |
Member
|
@bdach happy to leave in your hands 👍 |
This was referenced Feb 9, 2026
This was referenced Feb 13, 2026
This was referenced Mar 3, 2026
This was referenced Mar 16, 2026
This was referenced Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most important change here that contributes to the above crosstable, is that I've renamed
GetMatchmakingPools()toGetMatchmakingPoolsOfType(). This is for two reasons:The idea here is the server can add a
GetMatchmakingPools()(old name) method, redirect it to theQuickPlaytype, and old clients will continue behaving correctly.