First pass adjustments to new settings design#36486
Merged
bdach merged 23 commits intoppy:masterfrom Jan 27, 2026
Merged
Conversation
It's one of the more important sections so I want to make it easier to find.
peppy
added
type/cosmetic
bdach
reviewed
Jan 27, 2026
| } | ||
| else | ||
| content.BorderColour = Enabled.Value ? colourProvider.Light4 : colourProvider.Dark1; | ||
| // TODO: Support BackgroundColour? |
Collaborator
There was a problem hiding this comment.
is this TODO still supposed to be here?
Member
Author
There was a problem hiding this comment.
Yeah. this was added by @frenzibyte but is not used yet, so I'm not sure how/when to support it. In addition FormButton doesn't really work in settings yet.
I turned masking back on on these for better visuals (text masking aligns with rest of elements) but turns out this implicitly makes borders draw.
This comment was marked as off-topic.
This comment was marked as off-topic.
This was referenced Feb 11, 2026
This was referenced Mar 4, 2026
This was referenced Mar 16, 2026
This was referenced Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits for what has changed. I have more changes coming but these seem to stand alone quite amicably.