Fix panel expansion not being set on initial song select load#36456
Merged
bdach merged 3 commits intoppy:masterfrom Jan 27, 2026
Merged
Fix panel expansion not being set on initial song select load#36456bdach merged 3 commits intoppy:masterfrom
bdach merged 3 commits intoppy:masterfrom
Conversation
Member
|
I don't like the fix logic either. Especially with zero explanation from someone that hasn't worked on the classes before. |
peppy
added a commit
to peppy/osu
that referenced
this pull request
Jan 27, 2026
I'm not sure how this will hold out. I can't really explain it in a better way. I've tried about 10 other different iterations of this. I don't like this fix. If this is not mergeable I'll probably look to see if I can rewrite the expanded set state handling, because it's just ass right now. - Regressed in ppy#36404. - Closes ppy#36445. - Supersedes and closes ppy#36456.
peppy
added a commit
to peppy/osu
that referenced
this pull request
Jan 27, 2026
peppy
previously approved these changes
Jan 27, 2026
peppy
force-pushed
the
fix-panel-expansion-on-initial-load
branch
from
e641576 to
33a4420
Compare
peppy
approved these changes
Jan 27, 2026
Member
|
@bdach please double-check this one and make sure you agree with it. |
bdach
approved these changes
Jan 27, 2026
Collaborator
bdach
left a comment
bdach
left a comment
There was a problem hiding this comment.
seems to work and has tests. that's basically all that i require at this point because understanding what happens where and why in this code has long gone 🤷
This was referenced Jan 28, 2026
This was referenced Feb 9, 2026
This was referenced Feb 11, 2026
This was referenced Mar 4, 2026
This was referenced Mar 16, 2026
This was referenced Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36445.
Fixes a regression from #36404