Skip to content

Fix carousel items becoming incorrectly selected due to bindable leakage#36414

Merged
peppy merged 2 commits intoppy:masterfrom
peppy:fix-selection-woes
Jan 21, 2026
Merged

Fix carousel items becoming incorrectly selected due to bindable leakage#36414
peppy merged 2 commits intoppy:masterfrom
peppy:fix-selection-woes

Conversation

@peppy
Copy link
Copy Markdown
Member

@peppy peppy commented Jan 20, 2026

As discussed in discord. Fixed from multiple angles.

As discussed in discord. Fixed from multiple angles.
@peppy peppy requested a review from bdach January 20, 2026 16:31
@peppy peppy marked this pull request as ready for review January 21, 2026 05:51
@peppy
Copy link
Copy Markdown
Member Author

peppy commented Jan 21, 2026

Oops, this was marked as a draft due to a gh operational failure at my end.

No bugs here, just attempting to be safe.
@bdach
Copy link
Copy Markdown
Collaborator

bdach commented Jan 21, 2026

applied 718e90b as a precaution, please double check

@peppy
Copy link
Copy Markdown
Member Author

peppy commented Jan 21, 2026

Missed that one, thanks 👍

@peppy peppy merged commit 10dc131 into ppy:master Jan 21, 2026
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants