Fix skin saving crashing if hashable files are not present#36401
Merged
bdach merged 1 commit intoppy:masterfrom Jan 20, 2026
Merged
Fix skin saving crashing if hashable files are not present#36401bdach merged 1 commit intoppy:masterfrom
bdach merged 1 commit intoppy:masterfrom
Conversation
This ends up with a bit of an undefined behaviour, but it's already a bit of an edge case (files missing in the `files` folder that are references in the database). First and foremost, let's stop the exception. If we allow it to throw, it's impossible to exit the skin editor in this state. Closes ppy#36135.
peppy
added
type/reliability
bdach
approved these changes
Jan 20, 2026
Collaborator
bdach
left a comment
bdach
left a comment
There was a problem hiding this comment.
not gonna think about this too hard
github-project-automation
bot
moved this from Pending Review
to Done
in osu! team task tracker
This was referenced Jan 28, 2026
This was referenced Feb 9, 2026
This was referenced Mar 4, 2026
This was referenced Mar 16, 2026
This was referenced Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ends up with a bit of an undefined behaviour, but it's already a bit of an edge case (files missing in the
filesfolder that are references in the database).First and foremost, let's stop the exception. If we allow it to throw, it's impossible to exit the skin editor in this state.
Closes #36135.