Skip to content

Mod Select: Support numeric row hotkeys to quick select Presets#36392

Merged
peppy merged 9 commits intoppy:masterfrom
iwa:feat/numeric-hotkeys-for-presets-mod-select
Jan 22, 2026
Merged

Mod Select: Support numeric row hotkeys to quick select Presets#36392
peppy merged 9 commits intoppy:masterfrom
iwa:feat/numeric-hotkeys-for-presets-mod-select

Conversation

@iwa
Copy link
Copy Markdown
Contributor

@iwa iwa commented Jan 19, 2026

always thought the Mod select screen missed something by not having hotkeys to select presets, so I've tried to implement it

I've renamed the HandleHotkeyPressed method into HandleModHotkeyPressed so it could be differentiated with the one I created for presets

I initially overload the HandleHotkeyPressed method with the arguments to handle Presets, but I thought it wasn't clean enough
can still revert to overloading if that's what y'all prefer

logic is inspired by and implemented in the sequential hotkey logic, but currently also works with classic hotkey logic (cause why not?)

Example

Screen.Recording.2026-01-19.at.17.23.32.mov

@iwa
Copy link
Copy Markdown
Contributor Author

iwa commented Jan 20, 2026

refactored so everything is held into OnKeyDown

kept the renaming of HandleHotkeyPressed into HandleModHotkeyPressed so name's a bit more precise, want me to revert that?

@peppy peppy self-requested a review January 22, 2026 10:53
@peppy
Copy link
Copy Markdown
Member

peppy commented Jan 22, 2026

This needs test coverage.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 22, 2026
@peppy peppy enabled auto-merge January 22, 2026 16:20
@peppy peppy disabled auto-merge January 22, 2026 18:28
@peppy peppy merged commit 6f038bf into ppy:master Jan 22, 2026
6 of 9 checks passed
@iwa iwa deleted the feat/numeric-hotkeys-for-presets-mod-select branch January 22, 2026 20:49
@MegaGamer22
Copy link
Copy Markdown

MegaGamer22 commented Jan 23, 2026

I have to click to prevent the numbers from using the search bar instead of selecting the presets, am I missing something?
Edit: Remember to disable Automatically focus search text box in mod select.

@peppy
Copy link
Copy Markdown
Member

peppy commented Jan 24, 2026

that's correct. there's a setting to make the search box not focused by default, or you can press tab

@Loreos7
Copy link
Copy Markdown
Contributor

Loreos7 commented Jan 24, 2026

Resolves #19683.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants