Skip to content

Ensure diffcalc runs after mods get replaced during a ruleset change#36359

Merged
bdach merged 2 commits intoppy:masterfrom
LiquidPL:fix-diffcalc-ruleset-change
Jan 16, 2026
Merged

Ensure diffcalc runs after mods get replaced during a ruleset change#36359
bdach merged 2 commits intoppy:masterfrom
LiquidPL:fix-diffcalc-ruleset-change

Conversation

@LiquidPL
Copy link
Copy Markdown
Contributor

Resolves #36046.

@bdach bdach moved this from Inbox to Pending Review in osu! team task tracker Jan 16, 2026
@bdach bdach added area:song-select type/reliability Deals with game crashing or breaking in a serious way. labels Jan 16, 2026
Copy link
Copy Markdown
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine, but for future reference - "fixing" issues with schedules has not historically gone over well in several cases, so when applying one of those, it's generally a good idea to explain what is being achieved by the schedule (like in 49c92fb) to ensure no guesswork has to happen later if the schedule itself becomes another problem

@bdach bdach merged commit 952fd0d into ppy:master Jan 16, 2026
6 of 9 checks passed
@github-project-automation github-project-automation bot moved this from Pending Review to Done in osu! team task tracker Jan 16, 2026
@LiquidPL LiquidPL deleted the fix-diffcalc-ruleset-change branch January 16, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:song-select size/XS type/reliability Deals with game crashing or breaking in a serious way.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

InvalidCastExceptions raised due to performing diffcalcs on invalid ruleset/mod combinations

2 participants