Fix notification spam on websocket connection handshake failures#36349
Fix notification spam on websocket connection handshake failures#36349bdach merged 5 commits intoppy:masterfrom
Conversation
This can cause issues liek loss of replays, so it's worth notifying the user and keeping things visible.
peppy
added
the
area:online functionality
| /// </summary> | ||
| public static LocalisableString APIDisconnect => new TranslatableString(getKey(@"api_disconnect"), @"Connection to API was lost. Can't continue with online play."); | ||
|
|
||
| /// <summary> |
There was a problem hiding this comment.
I combined these because I don't think this is really adding anything. When you get kicked from multiplayer it's pretty obvious already, so using a single message to convey all online-service-interruption issues makes more sense to me.
I do not. |
|
|
||
| onError?.Invoke(exception); | ||
|
|
||
| if (exception is WebSocketException wse && wse.Message != @"The remote party closed the WebSocket connection without completing the close handshake.") |
There was a problem hiding this comment.
did you mean
| if (exception is WebSocketException wse && wse.Message != @"The remote party closed the WebSocket connection without completing the close handshake.") | |
| if (exception is WebSocketException wse && wse.Message == @"The remote party closed the WebSocket connection without completing the close handshake.") |
| return; | ||
| } | ||
|
|
||
| if (getCurrentScreen() is Player) |
There was a problem hiding this comment.
not sure what the intent of this is
| if (getCurrentScreen() is Player) | |
| if (getCurrentScreen() is SpectatorPlayer) |
is closer to what I would expect here, don't see much point posting notifications about spectator disconnecting when someone's watching a local replay
There was a problem hiding this comment.
it also affects replay upload, so at very least would need to match SubmittingPlayer as well.
If you want to be more granular I'd propose those two being switched on.
There was a problem hiding this comment.
it affecting replay upload is more our problem than the user's but it makes sense I guess.
would prefer SpectatorPlayer || SubmittingPlayer over the current guard
peppy
force-pushed
the
spectator-connection-disconnect-notify
branch
from
ffd0bb5 to
1313883
Compare
github-project-automation
bot
moved this from Pending Review
to Done
in osu! team task tracker
|
so you actually did some code work for russians, just not something that actually helps the connection... i mentioned this already but got ignored, please answer this time: everything under osu.ppy.sh is whitelisted, is it really impossible for you to at least change bm*.ppy.sh to bm*.osu.ppy.sh? |
Thanks for the suggestion, but that would come with wildcard SSL concerns (not impossible to resolve), and there's no guarantee they won't block the new subdomains. We've reached out to the russian authorities and heard back from them, are the beatmap mirrors still completely blocked? |
no osu domains are blocked. it's a domain whitelist (on cloudflare, OVH, DO, ...) and
they weren't completely blocked for everyone, only ~35% of internet users in russia are affected now, but more and more people will complain as the government expands their block to more cities (they do it slowly since april 2025). you will see on |
|
Anything new? Will forum purges continue forever, Kim? (Asking the unknown moderator) |
|
nothing new. please contact your government agencies to out more pressure. we are already in discussion to attempt to fix this. |
|
I did. Does this mean bm*.ppy.sh -> bm*.osu.ppy.sh is not happening? |
3 participants
RFC
Closes #36336 (and probably other issues I need to link).
Have not tested yet (@bdach did you have a way to repro that specific error code in your previous testing?)