Clean up HubClientConnector configuration#36328
Merged
peppy merged 3 commits intoppy:masterfrom Jan 13, 2026
Merged
Conversation
…rovided provider property The property used here is listed in SignalR documentation: https://learn.microsoft.com/en-us/aspnet/core/signalr/authn-and-authz?view=aspnetcore-10.0#bearer-token-authentication While in practice this probably has zero bearing on anything, theoretically the way proposed in this commit is more correct. As the documentation states, with some transports the token may need to be renewed if it expires, which providing it via a header as done previously would not achieve, while going through `API.AccessToken` every time will perform a token refresh if one is needed.
Clean-up from an old change (see ppy#28892 (comment)).
More clean-up.
bdach
added
code quality
peppy
approved these changes
Jan 13, 2026
This was referenced Jan 19, 2026
This was referenced Jan 28, 2026
This was referenced Feb 9, 2026
This was referenced Mar 4, 2026
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bunch of assorted minor changes that fell out from me looking into SignalR authentication for the refereeing client implementation. If anything here offends, relevant commits or the PR in its entirety can be dropped - any known functional concerns that these changes would fix are at most theoretical.
Replace manual specification of
Authorizationheader with SignalR-provided provider propertyThe property used here is listed in SignalR documentation. Not sure why it hasn't been used from the start, it's at least 8 years old.
While in practice this probably has zero bearing on anything, theoretically the way proposed in this commit is more correct. As the documentation states, with some transports the token may need to be renewed if it expires, which providing it via a header as done previously would not achieve, while going through
API.AccessTokenvia the accessor every time will perform a token refresh if one is needed.Remove no longer needed header alias for version hash
Clean-up from an old change (see #28892 (comment)).
Simplify proxy configuration
More clean-up while I'm here. Can't say I tested this at all.