Update form button UI/UX and support text wrapping#36324
Merged
peppy merged 3 commits intoppy:masterfrom Jan 14, 2026
Merged
Conversation
frenzibyte
added
type/cosmetic
peppy
reviewed
Jan 13, 2026
| { | ||
| backgroundColour = value; | ||
|
|
||
| if (IsLoaded && value != null) |
Member
There was a problem hiding this comment.
probably Debug.Assert(value != null) rather than this? since setting null here is super undefined behaviour in the state you have it.
Member
There was a problem hiding this comment.
also why isn't this calling updateState? BackgroundColour is used there too.
Move this logic inside updateState and use a standard flow instead?
peppy
approved these changes
Jan 14, 2026
This was referenced Jan 19, 2026
This was referenced Jan 28, 2026
This was referenced Feb 9, 2026
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be used in settings overlay.
Preview:
CleanShot.2026-01-12.at.23.51.45.mp4