Expand settings in ReplayPlayer by default#36308
Merged
peppy merged 1 commit intoppy:masterfrom Jan 12, 2026
Merged
Conversation
diquoks
commented
Jan 12, 2026
| { | ||
| public partial class PlayerSettingsOverlay : ExpandingContainer | ||
| { | ||
| public VisualSettings VisualSettings { get; private set; } |
Contributor
Author
There was a problem hiding this comment.
also removed this property because it wasn't used
|
Yeah it was one of my suggestion #36189. Should I mark it as answered ? |
Contributor
Author
yep, you can |
peppy
approved these changes
Jan 12, 2026
Member
peppy
left a comment
peppy
left a comment
There was a problem hiding this comment.
a bit cluttered, but probably ok
This was referenced Jan 19, 2026
This was referenced Jan 28, 2026
This was referenced Feb 9, 2026
This was referenced Mar 4, 2026
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i recently saw an suggestion to do this, but don't remember wherei think it's logical, since the settings have been displayed in a separate overlay for more than six months, and not on top of the gameplay itself, and for example, it can be difficult to expand section on phones