Localise some more notification/updater strings#36301
Conversation
diquoks
force-pushed
the
localisation/osu-game-notifications
branch
from
7621805 to
8a21c68
Compare
|
Please combine the commits from the other two into this one. |
…-notifications # Conflicts: # osu.Game/Localisation/NotificationsStrings.cs
…o localisation/osu-game-notifications # Conflicts: # osu.Game/Localisation/NotificationsStrings.cs
diquoks
changed the title
OsuGameOsuGame, MobileUpdateNotifier, NoActionUpdateManager & PerformFromMenuRunner
a couple of months ago bdach told me to split large localisation pull requests into smaller ones, so i decided not to create big one with notifications, but apparently i got too carried away with the separation @peppy could you tell me how best to split up pull requests so that they are easy to review and don't turn into spam? |
changes to the same strings file are best grouped together, otherwise each PR merge will conflict with the next. split PRs over 100-150 LoC change is a good ballpark. |
peppy
left a comment
peppy
left a comment
There was a problem hiding this comment.
make keys convey meaning to the localisers
| /// <summary> | ||
| /// "A newer release of osu! has been found ({0} → {1})." | ||
| /// </summary> | ||
| public static LocalisableString UpdateAvailable(string version, string latestTagName) => new TranslatableString(getKey(@"update_available"), @"A newer release of osu! has been found ({0} → {1}).", version, latestTagName); |
There was a problem hiding this comment.
parameters could be improved, probably oldVersion newVersion.
| /// <summary> | ||
| /// "Click here to download the new version, which can be installed over the top of your existing installation" | ||
| /// </summary> | ||
| public static LocalisableString UpdateMobile => new TranslatableString(getKey(@"update_mobile"), @"Click here to download the new version, which can be installed over the top of your existing installation"); |
There was a problem hiding this comment.
Also missing period.
there was no dot before, see https://github.com/diquoks/osu/blob/master/osu.Game/Updater/MobileUpdateNotifier.cs#L61
from now on, i will fix such things
| /// <summary> | ||
| /// "Check with your package manager / provider to bring osu! up-to-date!" | ||
| /// </summary> | ||
| public static LocalisableString UpdateNoAction => new TranslatableString(getKey(@"update_no_action"), @"Check with your package manager / provider to bring osu! up-to-date!"); |
peppy
changed the title
OsuGame, MobileUpdateNotifier, NoActionUpdateManager & PerformFromMenuRunner
peppy
changed the title
3 participants
No description provided.