Refactor UpdateableTeamFlag for use on team overlay#36286
Merged
peppy merged 2 commits intoppy:masterfrom Feb 10, 2026
Merged
Conversation
peppy
reviewed
Feb 10, 2026
osu.Game/Users/UserPanel.cs
Outdated
| protected Drawable CreateTeamLogo() => new UpdateableTeamFlag(User.Team) | ||
| { | ||
| Size = new Vector2(52, 26), | ||
| CornerRadius = 3.25f, |
Member
There was a problem hiding this comment.
I'm super not sure about this being calculated locally in every usage, where it used to be a known ratio. How many usages are there where it's disabled or doesn't match the ratio?
Also, it's a bit weird that Masking is turned on for this but that's still done at the base UpdateableTeamFlag level.
Contributor
Author
There was a problem hiding this comment.
The only usage would be the big flag on the team profile page. I believe I did it like this since I somehow couldn't figure out how to handle setting the default radius in a clean way when CornerRadius is not set. I'll send in a fix.
peppy
approved these changes
Feb 10, 2026
This was referenced Mar 3, 2026
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #32584.
Very much inspired by the respective component for displaying profile pictures on the user overlay