Extract user overlay actions button component#36236
Merged
peppy merged 2 commits intoppy:masterfrom Mar 10, 2026
Merged
Conversation
Contributor
Author
|
what happened with the tests here :o |
Contributor
Author
|
i don't think any of those failures are relevant to the PR, it just so happened that all four runs caught some flaky tests 🙈 |
Member
yeah i have them on my bucket list already... |
peppy
approved these changes
Mar 10, 2026
Member
peppy
left a comment
peppy
left a comment
There was a problem hiding this comment.
Seems fine. Could probably avoid generic abstraction but not worth fussing over.
This was referenced Mar 16, 2026
This was referenced Apr 6, 2026
This was referenced Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extracts the classes used for the actions dropdown on the user profile overlay to separate components, in preparation to be used on the team overlay (#32584).
Kinda RFC since I'm not sure if this is the best way to do this.