Skip to content

Adjust online beatmap query to fix potential crash #36235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdach merged 1 commit into from
Jan 6, 2026
Merged

Adjust online beatmap query to fix potential crash #36235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion osu.Game/Beatmaps/BeatmapManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,11 @@ public List<BeatmapSetInfo> GetAllUsableBeatmapSets()
/// <returns>A matching local beatmap info if existing and in a valid state.</returns>
public BeatmapInfo? QueryOnlineBeatmapId(int id) => Realm.Run(r =>
r.All<BeatmapInfo>()
.ForOnlineId(id).SingleOrDefault()?.Detach());
.ForOnlineId(id)
// See https://github.com/ppy/osu/issues/36234 for why this isn't a SingleOrDefault().
.FirstOrDefault()
?.Detach()
);

/// <summary>
/// A default representation of a WorkingBeatmap to use when no beatmap is available.
Expand Down