Skip to content

Adjust message on successful report to match bancho#36023

Merged
peppy merged 1 commit intoppy:masterfrom
bdach:report-message-pm
Dec 16, 2025
Merged

Adjust message on successful report to match bancho#36023
peppy merged 1 commit intoppy:masterfrom
bdach:report-message-pm

Conversation

@bdach
Copy link
Copy Markdown
Collaborator

@bdach bdach commented Dec 16, 2025

Addresses #36004.

In public channels:
Screenshot 2025-12-16 at 11 10 45

In PMs:
Screenshot 2025-12-16 at 11 21 39

Caveats:

  • Not adding localisation because the previous implementation was .ToString()ing anyway.
  • Would have made the abuse e-mail a link but mailto: doesn't work with MessageFormatter and I don't want to go into that right now.
  • The message almost matches stable. The "almost" is because it doesn't mention the /ignore chat command. I was just going to implement the command, but I went to check what it does, and backed away slowly because it has like weird scoping to chat, highlights, and/or PMs, so nope.avi.

Addresses ppy#36004.

Not adding localisation because the previous implementation was
`.ToString()`ing anyway.

Would have made the abuse e-mail a link but `mailto:` doesn't work with
`MessageFormatter` and I don't want to go into that right now.

The message *almost* matches stable. The "almost" is because it doesn't
mention the `/ignore` chat command. I was just going to implement the
command, but I went to check what it does, and backed away slowly
because it has like weird scoping to chat, highlights, and PMs, so
`nope.avi`.
@bdach bdach self-assigned this Dec 16, 2025
@bdach bdach added area:overlay-chat quick fix Tasks which were taken on because they take no time to fix labels Dec 16, 2025
@bdach bdach moved this from Inbox to Pending Review in osu! team task tracker Dec 16, 2025
@peppy peppy merged commit ac213c9 into ppy:master Dec 16, 2025
5 of 9 checks passed
@github-project-automation github-project-automation bot moved this from Pending Review to Done in osu! team task tracker Dec 16, 2025
@bdach bdach deleted the report-message-pm branch December 16, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:overlay-chat quick fix Tasks which were taken on because they take no time to fix size/S

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants