Skip to content

Fix replay fail indicator not using fail sample from beatmap skin #36020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peppy merged 1 commit into from
Dec 16, 2025
Merged

Fix replay fail indicator not using fail sample from beatmap skin #36020

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions osu.Game/Screens/Play/ReplayPlayer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
using osu.Game.Screens.Play.PlayerSettings;
using osu.Game.Screens.Ranking;
using osu.Game.Screens.Select.Leaderboards;
using osu.Game.Skinning;
using osu.Game.Users;

namespace osu.Game.Screens.Play
Expand Down Expand Up @@ -100,15 +101,18 @@ private void load(OsuConfigManager config)
playbackSettings.UserPlaybackRate.BindTo(master.UserPlaybackRate);

HUDOverlay.PlayerSettingsOverlay.AddAtStart(playbackSettings);
AddInternal(failIndicator = new ReplayFailIndicator(GameplayClockContainer)
AddInternal(new RulesetSkinProvidingContainer(GameplayState.Ruleset, GameplayState.Beatmap, Beatmap.Value.Skin)
{
GoToResults = () =>
Child = failIndicator = new ReplayFailIndicator(GameplayClockContainer)
{
if (!this.IsCurrentScreen())
return;

ValidForResume = false;
this.Push(new SoloResultsScreen(Score.ScoreInfo));
GoToResults = () =>
{
if (!this.IsCurrentScreen())
return;

ValidForResume = false;
this.Push(new SoloResultsScreen(Score.ScoreInfo));
}
}
});
}
Expand Down
Loading