Skip to content

Slightly delay song select leaderboard's loading placeholder to avoid flashing during local score retrieval #35969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdach merged 1 commit into from
Dec 11, 2025
Merged

Slightly delay song select leaderboard's loading placeholder to avoid flashing during local score retrieval #35969

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion osu.Game/Screens/SelectV2/BeatmapLeaderboardWedge.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,15 +407,27 @@ private void clearScores()

private LeaderboardState displayedState;

private ScheduledDelegate? loadingShowDelegate;

protected void SetState(LeaderboardState state)
{
if (state == displayedState)
return;

if (state == LeaderboardState.Retrieving)
loading.Show();
{
// Slight delay so this doesn't display for a few silly frames for local score retrievals.
loadingShowDelegate ??= Scheduler.AddDelayed(() => loading.Show(), 200);
}
else
{
loadingShowDelegate?.Cancel();
loadingShowDelegate = null;

loading.Hide();
}

loading.Hide();

displayedState = state;

Expand Down
Loading