Fix cursor trail detaching from cursor when adjusting cursor scale#35802
Merged
bdach merged 9 commits intoppy:masterfrom Dec 10, 2025
Merged
Fix cursor trail detaching from cursor when adjusting cursor scale#35802bdach merged 9 commits intoppy:masterfrom
bdach merged 9 commits intoppy:masterfrom
Conversation
bdach
requested changes
Nov 27, 2025
- Revert changes to CursorTrail.cs made during 79bfe78
- Add CursorScale property to CursorTrail and adjust for scaling
Contributor
Author
|
These changes should fix the cursor trail disappearing on skin change |
bdach
requested changes
Dec 4, 2025
Contributor
Author
|
Implemented those change and it seems to be working as expected now. I've also simplified the test for it. |
Contributor
Author
|
I've noticed another issue. The skin cursor trail still shows the old one during the pause menu.
I'm not sure how to feel about forcing a texture update in the case that we switch between a legacy skin and a non-legacy skin. And at the same time, I feel like the PR is moving far from what it was intending to fix. |
Collaborator
Out of scope, tracked separately at #7285. |
bdach
approved these changes
Dec 9, 2025
This was referenced Jan 1, 2026
This was referenced Jan 1, 2026
This was referenced Jan 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First PR.
Would fix #35734
I'm not sure if the tests are sufficient