Add sample set displays & selection controls to editor

[bdach]

Below 20 custom sample sets, they are shown as ternary buttons.

2025-10-24.12-13-08.mov

Above 20 custom sample sets, they are shown in a dropdown (yes there are actual cases of this as I've been informed by the NAT; one example being this mapset, among other keysounded mapsets)

2025-10-24.12-14-05.mov

As a bonus, to make determining what the heck is actually changing when adjusting these controls, the full set of applicable sounds now plays on adding/removing additions, changing their banks, as well as changing the custom set (if any).

For now there are no user-facing controls to add the samples to the map yourself, you have to know how to name the files and edit-externally them in yourself. For now.

---

RFC. Further progress towards #35370.

[ziv-vy]

I know that this shouldn't be the place this is discussed, but there is no linked issue or discussions thread (edit: that would propose a design).

I have no clue what is going on here. I think there may be too many toggles and it would seriously hurt the accessibility of the editor. Could the team reconsider and put this behind some kind of advanced mode, or redesign this altogether?

[bdach]

@ziv-vy there is a linked issue actually just at the end of my opening post

anyway read #29280

I'm not even done with this feature and you're free to not even use the sample set feature, none of those new toggles or dropdowns appear if you don't have custom samples in the beatmap

[minetoblend]

I gave this a little test drive and UI wise I really like it.

Only thing I noticed is that I think the preview samples are going off multiple times per button click.
When you click one of the sample buttons multiple times it sounds slightly different on the first click, likely as a result of this.

I recorded a video of it with all other ui sounds muted & log statements for each sample playback. I'm pretty sure only SampleEditPopover.playDemoSample actually produces a sound though, as SampleSetTernaryButton.DemoSamples appears to never be assigned.

2025-10-30.23-26-27.mp4

Beatmap I noticed this on (first couple notes of top diff): https://osu.ppy.sh/beatmapsets/2412260#osu/5238579
It's a lot less (or even not at all) audible on other maps I've tried to replicate it with.

[bdach]

Only thing I noticed is that I think the preview samples are going off multiple times per button click. When you click one of the sample buttons multiple times it sounds slightly different on the first click, likely as a result of this.

Probably fixed in 8755a01?

SampleSetTernaryButton.DemoSamples appears to never be assigned.

That shouldn't even exist, I forgot to remove it. Removed in 901044d.

[minetoblend]

The demo sample plays normally for me now. One more small thing I just noticed is that the default button click sounds are muted on the sample index buttons but the addition toggles still play them, which is far louder than most beatmap samples.

[peppy]

The demo sample plays normally for me now. One more small thing I just noticed is that the default button click sounds are muted on the sample index buttons but the addition toggles still play them, which is far louder than most beatmap samples.

Fixed this before I noticed your comment 🙃 13aeed1