Fix weird follow circle display when rewinding through sliders in editor #31864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not a parent. The follow circle is directly part of the slider itself.
peppy
commented
Feb 12, 2025
Comment on lines
+70
to
+71
| // Immediately play out any pending transforms from press/release | ||
| FinishTransforms(true); |
There was a problem hiding this comment.
This is the only part required for the actual fix.
peppy
commented
Feb 12, 2025
| { | ||
| ((DrawableSlider?)ParentObject)?.Tracking.BindValueChanged(tracking => |
There was a problem hiding this comment.
This may look bad but it's not that bad because FollowCircle has a 1:1 relationship with a DrawableHitObject. This was subscribing twice somehow, but "only" twice.
smoogipoo
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31812.
This goes much deeper (so many gameplay things look wrong in rewind). I still believe the correct path forward is to not use transforms here. I did consider doing that for this series of classes, but it's more than a 30 minute change and I don't want to go down that rabbit hole just yet.