-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Std length bonus fix by calculating consistency for each skill #31483
base: pp-dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please at least make sure your PR compiles before submitting
- Commit history is full of unrelated stuff
- No code quality, changes are sprinkled all over the repository for some reason (why are there changes in a general
PerformanceCalculator
??) - This doesn't seem to fix the length bonus at all (checking on a test map, 80s of filler and 20s of high difficulty gives roughly the same pp as just 100s of high difficulty) and instead randomly deflates values
- Replace the length bonus with a new bonus dependant on object difficulty #30924 does pretty much the same concept (making length bonus be aware of the map difficulty)
So far this PR is pretty much unacceptable
3a6fef7
to
1b9de2c
Compare
d1bf635
to
1ca9760
Compare
1ca9760
to
8532e80
Compare
921023c
to
7907337
Compare
694b40a
to
4c8a193
Compare
d0b73c1
to
7988bf1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to revise the factor calculation because dividing by the maximum difficulty doesn't produce the expected results and yields an incorrect value.
3c03f57
to
18b4eb7
Compare
f63bbf7
to
0ff2746
Compare
fd759ca
to
0a34c45
Compare
bd8f101
to
85e6dd6
Compare
The change modifies:
For all gamemode:
For standard only:
taiko (separated here: https://github.com/TheDark98/osu/tree/Length-Bonus-Fix-Taiko)
mania (separated here: https://github.com/TheDark98/osu/tree/Length-Bonus-Fix-Mania)