Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Std length bonus fix by calculating consistency for each skill #31483

Open
wants to merge 5 commits into
base: pp-dev
Choose a base branch
from

Conversation

TheDark98
Copy link

@TheDark98 TheDark98 commented Jan 11, 2025

The change modifies:

For all gamemode:

  • New value, DifficultyFactor, to calculate the proportion between the average difficulty of hits and the maximum hit difficulty, represented by a value from 0 to 1.

For standard only:

  • DifficultyFactor for aim and speed skills.
  • New PP bonus calculation.
  • New lenth bonus formula.

taiko (separated here: https://github.com/TheDark98/osu/tree/Length-Bonus-Fix-Taiko)

mania (separated here: https://github.com/TheDark98/osu/tree/Length-Bonus-Fix-Mania)

@TheDark98 TheDark98 marked this pull request as draft January 11, 2025 08:14
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 11, 2025
@TheDark98 TheDark98 marked this pull request as ready for review January 11, 2025 10:56
@TheDark98 TheDark98 marked this pull request as draft January 11, 2025 11:24
@stanriders stanriders requested a review from a team January 13, 2025 08:30
Copy link
Member

@stanriders stanriders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please at least make sure your PR compiles before submitting
  2. Commit history is full of unrelated stuff
  3. No code quality, changes are sprinkled all over the repository for some reason (why are there changes in a general PerformanceCalculator??)
  4. This doesn't seem to fix the length bonus at all (checking on a test map, 80s of filler and 20s of high difficulty gives roughly the same pp as just 100s of high difficulty) and instead randomly deflates values
  5. Replace the length bonus with a new bonus dependant on object difficulty #30924 does pretty much the same concept (making length bonus be aware of the map difficulty)

So far this PR is pretty much unacceptable

@TheDark98 TheDark98 force-pushed the Length-Bonus-Fix branch 3 times, most recently from 3a6fef7 to 1b9de2c Compare January 14, 2025 15:15
@pull-request-size pull-request-size bot added size/M and removed size/L labels Jan 14, 2025
@TheDark98 TheDark98 force-pushed the Length-Bonus-Fix branch 2 times, most recently from d1bf635 to 1ca9760 Compare January 14, 2025 15:30
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 14, 2025
@TheDark98 TheDark98 requested a review from stanriders January 14, 2025 15:30
@TheDark98 TheDark98 marked this pull request as ready for review January 14, 2025 15:41
@TheDark98 TheDark98 force-pushed the Length-Bonus-Fix branch 2 times, most recently from 921023c to 7907337 Compare January 14, 2025 15:48
@TheDark98 TheDark98 changed the title Fix the length bonus by determining how much of the map is hard Std length bonus fix by calculating consistency for each skill Jan 14, 2025
@TheDark98 TheDark98 force-pushed the Length-Bonus-Fix branch 2 times, most recently from 694b40a to 4c8a193 Compare January 14, 2025 20:56
@pull-request-size pull-request-size bot added size/M and removed size/L labels Jan 14, 2025
@TheDark98 TheDark98 force-pushed the Length-Bonus-Fix branch 2 times, most recently from d0b73c1 to 7988bf1 Compare January 14, 2025 21:49
Copy link
Author

@TheDark98 TheDark98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to revise the factor calculation because dividing by the maximum difficulty doesn't produce the expected results and yields an incorrect value.

osu.Game/Rulesets/Difficulty/Skills/StrainSkill.cs Outdated Show resolved Hide resolved
osu.Game.Rulesets.Osu/Difficulty/Skills/OsuStrainSkill.cs Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 15, 2025
@TheDark98 TheDark98 force-pushed the Length-Bonus-Fix branch 3 times, most recently from 3c03f57 to 18b4eb7 Compare January 16, 2025 05:36
@pull-request-size pull-request-size bot added size/M and removed size/L labels Jan 16, 2025
@TheDark98 TheDark98 force-pushed the Length-Bonus-Fix branch 6 times, most recently from f63bbf7 to 0ff2746 Compare January 16, 2025 06:00
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants