Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix angle bonuses calculating repetition incorrectly, apply distance scaling to wide bonus #31320

Merged
merged 6 commits into from
Jan 6, 2025

Conversation

stanriders
Copy link
Member

@stanriders stanriders commented Dec 28, 2024

Round 3 of angle bonuses fixes.

This change fixes a few things:

  1. Acute angle bonus doing comparison to the previous angle after applying velocity and bpm/distance multipliers
  2. Wide angle bonus awarding bonus for distance < radius which makes stacked patterns give more difficulty than they should

https://pp.huismetbenen.nl/rankings/players/fix-angle-bonuses

@stanriders
Copy link
Member Author

!diffcalc
RULESET=osu
OSU_A=https://github.com/ppy/osu/tree/pp-dev
OSU_B=#31320

Copy link

github-actions bot commented Jan 5, 2025

tsunyoku
tsunyoku previously approved these changes Jan 6, 2025
@tsunyoku tsunyoku enabled auto-merge (squash) January 6, 2025 14:28
@tsunyoku tsunyoku merged commit 76ac11f into ppy:pp-dev Jan 6, 2025
7 of 8 checks passed
@stanriders stanriders deleted the fix-angle-bonuses branch January 6, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Pending Deploy
Development

Successfully merging this pull request may close these issues.

2 participants