Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the length bonus with a new bonus dependant on object difficulty #30924

Open
wants to merge 21 commits into
base: pp-dev
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
fcf7e00
create clean branch with length changes
TextAdventurer12 Nov 27, 2024
9bfcb64
add a log to aim length so it doesn't explode on really really long c…
kwotaq Nov 27, 2024
ea53e98
fix in line
kwotaq Nov 27, 2024
d01d01a
fix sliderfactor on touch device
TextAdventurer12 Nov 29, 2024
1539ce0
fix sliderfactor on relax
TextAdventurer12 Nov 29, 2024
67560f1
Merge branch 'ppy:master' into clean-length
TextAdventurer12 Nov 29, 2024
e7694d4
fix code quality
TextAdventurer12 Dec 8, 2024
40a9719
code quality fixes
kwotaq Dec 11, 2024
609988d
more code quality fixes
kwotaq Dec 11, 2024
4fb1658
Merge pull request #20 from kwotaq/clean-length-
TextAdventurer12 Dec 11, 2024
cd08668
apply the same length bonus to sliderless aim
kwotaq Dec 11, 2024
0270051
Merge pull request #21 from kwotaq/fix-aim-length-bonus
TextAdventurer12 Dec 12, 2024
c7889b5
remove dev difficulty attributes
TextAdventurer12 Dec 12, 2024
3871ec7
running code is for losers, just don't make a mistake
TextAdventurer12 Dec 12, 2024
ae5bffa
make curves start from 1, remove ringtone nerf
kwotaq Dec 17, 2024
ee45d6d
Merge pull request #24 from kwotaq/curve-change
TextAdventurer12 Dec 18, 2024
88b99dd
fix comment formatting
kwotaq Dec 18, 2024
9cb6ba8
Merge pull request #28 from kwotaq/fix-formatting
TextAdventurer12 Dec 18, 2024
8d52313
Merge branch 'pp-dev' into clean-length
stanriders Dec 26, 2024
f139547
make logs make more sense
kwotaq Jan 2, 2025
7b099ec
Merge pull request #29 from kwotaq/curve-changes
TextAdventurer12 Jan 3, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove dev difficulty attributes
  • Loading branch information
TextAdventurer12 committed Dec 12, 2024
commit c7889b50dd6cdefb8005a83a4765f5cbe3423181
8 changes: 0 additions & 8 deletions osu.Game.Rulesets.Osu/Difficulty/OsuDifficultyAttributes.cs
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,6 @@ public class OsuDifficultyAttributes : DifficultyAttributes
[JsonProperty("speed_difficult_strain_count")]
public double SpeedDifficultStrainCount { get; set; }

// DEV ATTRIBUTE - DO NOT STORE
[JsonProperty("aim_relevant_object_count")]
public double AimRelevantObjectCount { get; set; }

// DEV ATTRIBUTE - DO NOTE STORE
[JsonProperty("speed_relevant_object_count")]
public double SpeedRelevantObjectCount { get; set; }

/// <summary>
/// The perceived approach rate inclusive of rate-adjusting mods (DT/HT/etc).
/// </summary>
Expand Down
Loading