Replace indexed skill access with skills.First(s is ...)
#30034
+36
−10
GitHub Actions / Test Results (Windows, MultiThreaded)
failed
Sep 28, 2024 in 0s
10520 passed, 2 failed and 74 skipped
❌ TestResults-Windows-MultiThreaded.trx
10596 tests were completed in 2851s with 10520 passed, 2 failed and 74 skipped.
| Test suite | Passed | Failed | Skipped | Time |
|---|---|---|---|---|
| osu.Game.Rulesets.Mania.Tests.Editor.TestSceneManiaSelectionHandler | 4✅ | 1❌ | 2s | |
| osu.Game.Tests.Visual.SongSelect.TestSceneBeatmapRecommendations | 11✅ | 1❌ | 19s |
❌ osu.Game.Rulesets.Mania.Tests.Editor.TestSceneManiaSelectionHandler
✅ TestConstructor
✅ TestHorizontalFlipOverPlayfield
✅ TestHorizontalFlipOverSelection
❌ TestOffScreenObjectsRemainSelectedOnColumnChange
all objects in last column
✅ TestVerticalFlip
❌ osu.Game.Tests.Visual.SongSelect.TestSceneBeatmapRecommendations
❌ TestBestRulesetIsRecommended
"recommended beatmap displayed" timed out
✅ TestBestRulesetIsRecommended
✅ TestConstructor
✅ TestConstructor
✅ TestCorrectStarRatingIsUsed
✅ TestCorrectStarRatingIsUsed
✅ TestCurrentRulesetIsRecommended
✅ TestCurrentRulesetIsRecommended
✅ TestPresentedBeatmapIsRecommended
✅ TestPresentedBeatmapIsRecommended
✅ TestSecondBestRulesetIsRecommended
✅ TestSecondBestRulesetIsRecommended
Annotations
Check failure on line 0 in TestResults-Windows-MultiThreaded.trx
github-actions / Test Results (Windows, MultiThreaded)
osu.Game.Rulesets.Mania.Tests.Editor.TestSceneManiaSelectionHandler ► TestOffScreenObjectsRemainSelectedOnColumnChange
Failed test found in:
TestResults-Windows-MultiThreaded.trx
Error:
all objects in last column
Raw output
all objects in last column
at osu.Framework.Threading.ScheduledDelegate.InvokeTask()
at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
at osu.Framework.Threading.Scheduler.Update()
at osu.Framework.Graphics.Drawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Platform.GameHost.UpdateFrame()
at osu.Framework.Threading.GameThread.processFrame()
at osu.Framework.Threading.GameThread.<createThread>g__runWork|70_0()
Check failure on line 541 in osu.Game/Tests/Visual/OsuTestScene.cs
github-actions / Test Results (Windows, MultiThreaded)
osu.Game.Tests.Visual.SongSelect.TestSceneBeatmapRecommendations ► TestBestRulesetIsRecommended
Failed test found in:
TestResults-Windows-MultiThreaded.trx
Error:
"recommended beatmap displayed" timed out
Raw output
"recommended beatmap displayed" timed out
at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in D:\a\osu\osu\osu.Game\Tests\Visual\OsuTestScene.cs:line 541
at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)
Loading