Make sliderless aim in fact sliderless #29993
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsunyoku
suggested changes
Nov 7, 2024
osu.Game.Rulesets.Osu/Difficulty/Evaluators/FlashlightEvaluator.cs
Outdated
Show resolved
Hide resolved
eeliogata
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of this PR - #27303
Current aim calculation have a flaw of sliderless aim still accounting for sliders. This happens because of usage of
LazyJumpDistanceas a main distance metric.This PR is fixing this by adding
JumpDistanceas true sliderless metric, using it instead ofLazyJumpDistance.This can introduce very rare cases where sliderless aim is worth more than normal aim (because of velocity change bonus). To account for this - sanity check for
SliderFactorwas added.The effect of this is minimal. It can be seen the best on this map - https://osu.ppy.sh/beatmapsets/594751#osu/1257904
Before:
After:
