Buff precision difficulty rating in osu! #28877
Draft
+21
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smoogipoo can we get a sheet please |
|
!diffcalc |
Givikap120
reviewed
Jul 17, 2024
| @@ -155,8 +160,7 @@ private void setDistances(double clockRate) | |||
|
|
|||
| if (BaseObject.Radius < 30) | |||
| { | |||
| float smallCircleBonus = Math.Min(30 - (float)BaseObject.Radius, 5) / 50; | |||
| scalingFactor *= 1 + smallCircleBonus; | |||
| SmallCircleBonus = 1.0 + Math.Min(30 - BaseObject.Radius, 30) / 38; | |||
There was a problem hiding this comment.
why do you even need Math.Min here?
Givikap120
reviewed
Jul 17, 2024
| @@ -74,7 +74,7 @@ public static double EvaluateDifficultyOf(DifficultyHitObject current, bool with | |||
| // Rewarding angles, take the smaller velocity as base. | |||
| double angleBonus = Math.Min(currVelocity, prevVelocity); | |||
|
|
|||
| wideAngleBonus = calcWideAngleBonus(currAngle); | |||
| wideAngleBonus = calcWideAngleBonus(lastAngle); | |||
There was a problem hiding this comment.
don't really understand why it's changed from currAngle to lastAngle
Givikap120
reviewed
Jul 17, 2024
|
|
||
| if (distance < 1) | ||
| { | ||
| wideAngleBonus *= 1 - 0.35 * (1 - distance); |
There was a problem hiding this comment.
this thing is not even working
need to check last and lastlastlast (💀) instead
EDIT: oopsie, I was wrong, it was not working cuz I changed angle for bonus from prev to curr
|
Also, this requires more advanced considerations like very short and spiky maps potentially being extremely overweight (mentioned by lolu) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR buffs precision (cs>5.5) maps in osu!
It's loosely based on this PR but instead of nerfing wide angle bonus based on acuteness of surrounding angles it's checking if the wide bonus comes from patterns that go back-and-forth through a central object which is usually easier to hit because your hand already knows the position of the center point.
As a consequence it changes the wide bonus calculation from current hitobject to the previous one which affects values on maps not directly affected by the precision buff itself.