Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a bunch of rhythm difficulty calculation fixes #28871

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Implement a bunch of rhythm difficulty calculation fixes #28871

wants to merge 28 commits into from

Conversation

stanriders
Copy link
Member

@stanriders stanriders commented Jul 15, 2024 •
edited
Loading

This PR addresses a couple of rhythm evaluation issues in osu!:

  1. Removes island length size bonus completely and uncaps island size (was limited to 7 before)
  2. Heavily nerf repeated islands such as triples in slowmotion (https://www.desmos.com/calculator/w9dtmvku2t)
  3. Changes delta difference comparisons to use hitwindow-based epsilon
  4. Buffs initial rhythm bonus
  5. Fixes island comparisons to use delta as well as size
  6. Considers doubletappness of islands
  7. Refactor

Values can be checked here

@stanriders stanriders requested a review from a team July 15, 2024 09:58
@smoogipoo
Copy link
Contributor

!diffcalc

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 16, 2024 •
edited
Loading

Target: #28871
Spreadsheet: https://docs.google.com/spreadsheets/d/1RjFSJwUQ_LW1wHNSeap2CwOXwwM9rm13hEqz_krZobY/edit

@smoogipoo
Copy link
Contributor

!diffcalc

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 20, 2024 •
edited
Loading

Difficulty calculation failed: https://github.com/ppy/osu/actions/runs/10018306415

@stanriders
Tweak some values
3acd00b
@stanriders
Don't cap max island size, make repetition nerf more lenient on high …
f1adc6f 
…bpm, adjust balancing
@stanriders
Scale difficulty with doubletapness, make kicksliders not reduce the …
ce8286d 
…difficulty of the next object, adjust balancing
@stanriders
Adjust max history by clockrate to make rhythm calculation more consi…
ed45c94 
…stent between rates
@stanriders
Reduce repetition nerf for non-consecutive islands
7fda8bc
@stanriders
Remove kickslider changes
3398497
@stanriders
Merge branch 'master' into rhythm-fixes
d544498
@stanriders
Reduce ratio for island size 1
5e8174f
@stanriders
Refactor
db626f1
@stanriders
Reduce ratio if we're starting island counting after a slider
738d4bc
@stanriders
Balancing
863a74f
@stanriders
More balancing
145731b
@stanriders
Reduce history max overall instead of using clock rate
bee18b0
@stanriders
Adjust multipliers
c9ce7d2
@stanriders
Move slider-related ratio multiplier out of the delta switch block, a…
0bad5e4 
…dd nerf for ratios with delta difference fractions that are too big, adjust consts
@stanriders
Slight refactoring
732a114
@stanriders
Use List instead of Dictionary for island counting, minor adjustm…
202364b 
…ents
apollo-dw
apollo-dw approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@apollo-dw apollo-dw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanriders
Copy link
Member Author

@smoogipoo this change is good to go

@tsunyoku tsunyoku mentioned this pull request Sep 25, 2024
Open
Givikap120
Givikap120 reviewed Sep 27, 2024
View reviewed changes
osu.Game.Rulesets.Osu/Difficulty/Evaluators/RhythmEvaluator.cs
}

// scale down the difficulty if the object is doubletappable
double doubletapness = prevObj.GetDoubletapness((OsuDifficultyHitObject?)prevObj.Next(0));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currObj?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Givikap120 Givikap120 Givikap120 left review comments

@tsunyoku tsunyoku tsunyoku approved these changes

@apollo-dw apollo-dw apollo-dw approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area:difficulty ruleset/osu! size/L
Projects
Difficulty calculation changes
Status: Pending Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stanriders @smoogipoo @tsunyoku @apollo-dw @Givikap120