Bypass external link dialog for links on the trusted osu! domain #28363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joehuu
reviewed
May 30, 2024
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
The `Strings` suffix is not supposed to be in here, judging by other localisation classes.
bdach
reviewed
May 31, 2024
| @@ -170,6 +173,8 @@ public partial class MenuImage : OsuClickableContainer | |||
|
|
|||
| private Sprite flash = null!; | |||
|
|
|||
| public override bool IsPresent => base.IsPresent || Scheduler.HasPendingTasks; | |||
There was a problem hiding this comment.
It's a safety for
osu/osu.Game/Screens/Menu/OnlineMenuBanner.cs
Lines 214 to 218 in 53b7c29
I will admit I spent over 1 hour making the test for this work. It turned out that online content was replacing the test content in headless only, amongst other issues. I'm not 100% sure this is required, but it feels like it may be for the an edge case where the banner somehow fades out before the delay is reached.
bdach
approved these changes
May 31, 2024
peppy
added a commit
to peppy/osu
that referenced
this pull request
Oct 7, 2024
peppy
added a commit
to peppy/osu
that referenced
this pull request
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of addresses #28055 for trusted links at least.