Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logo to v4b #28143

Merged
merged 5 commits into from
May 10, 2024
Merged

Update logo to v4b #28143

merged 5 commits into from
May 10, 2024

Conversation

peppy
Copy link
Member

@peppy peppy commented May 10, 2024

  • resources bump
  • Test windows icon looks good – has custom <=48px text size (and was made using macOS preview, which I haven't tested before for a windows .ico)
  • Update android iconset

Here's an android export from my generator in case it's useful in updating that side: Android icons (iOS).zip (@bdach I remember last time this was insufficient so feel free to make a call on it and generate yourself if required)

@peppy
Copy link
Member Author

peppy commented May 10, 2024

Windows seems okay from here.

@bdach
Copy link
Collaborator

bdach commented May 10, 2024

@bdach I remember last time this was insufficient so feel free to make a call on it and generate yourself if required

Yeah those don't cut it anymore since android changed their icon guidelines. Have updated to how I believe they should look like these days.

Is there a resources bump coming for this?

@bdach bdach enabled auto-merge May 10, 2024 10:57
@bdach bdach merged commit 5285b35 into ppy:master May 10, 2024
9 of 11 checks passed
@peppy peppy deleted the update-logo-v4b branch May 12, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants