Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Taiko Classic HD, HR and HDHR to better match stable #27136

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix codeinspect issues
  • Loading branch information
vunyunt committed Feb 12, 2024
commit 46b2c123a6911b079d2c2c24af98ef51695cb4d7
2 changes: 0 additions & 2 deletions osu.Game.Rulesets.Taiko/Mods/TaikoModClassic.cs
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ public class TaikoModClassic : ModClassic, IApplicableToDrawableRuleset<TaikoHit

private readonly BindableFloat hiddenInitialAlpha = new BindableFloat(hd_base_initial_alpha);


public void ApplyToDrawableRuleset(DrawableRuleset<TaikoHitObject> drawableRuleset)
{
var drawableTaikoRuleset = (DrawableTaikoRuleset)drawableRuleset;
Expand All @@ -47,7 +46,6 @@ public void ApplyToDrawableRuleset(DrawableRuleset<TaikoHitObject> drawableRules

TaikoModHidden? hidden = mods.OfType<TaikoModHidden>().FirstOrDefault();


if (mods.OfType<TaikoModHardRock>().Any())
{
// For hardrock, the playfield time range is clamped to within classicMaxTimeRange and the equivalent
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ protected override void Update()
relativeHeight *= CurrentAspect.Value / MinimumAspect.Value;
}


// Limit the maximum relative height of the playfield to one-third of available area to avoid it masking out on extreme resolutions.
relativeHeight = Math.Clamp(relativeHeight, MinimumRelativeHeight.Value, MaximumRelativeHeight.Value);

Expand Down
Loading