Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change S rank to require no miss #26630

Merged
merged 24 commits into from
Jan 24, 2024
Merged

Change S rank to require no miss #26630

merged 24 commits into from
Jan 24, 2024

Commits on Jan 22, 2024

  1. Change S rank to require no miss

    @peppy
    peppy committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    c8521b4 View commit details
    Browse the repository at this point in the history

  2. Update test in line with new rank definitions always being applied

    @peppy
    peppy committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    bb1eab5 View commit details
    Browse the repository at this point in the history

  3. Move BackgroundDataStoreProcessor to better namespace

    @peppy
    peppy committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    4eba3b5 View commit details
    Browse the repository at this point in the history

  4. Add migration

    @peppy
    peppy committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    644e7d6 View commit details
    Browse the repository at this point in the history

  5. Adjust results screen to handle S->A rank adjustment when misses are … 

    …present
    @peppy
    peppy committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    83f9118 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into s-rank-change

    @bdach
    bdach committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    5bae907 View commit details
    Browse the repository at this point in the history

  7. Make RankFromScore()'s dictionary param readonly 

    Just to make sure nobody tries any "funny" business.
    @bdach
    bdach committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    cb8ec48 View commit details
    Browse the repository at this point in the history

  8. Fix back-to-front conditional in taiko processor 

    Would be weird to degrade a score due to *no* misses wouldn't it?
    @bdach
    bdach committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    20ed7e1 View commit details
    Browse the repository at this point in the history

  9. Remove remnant of old implementation of showing "A due to misses"

    @bdach
    bdach committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    45dc9de View commit details
    Browse the repository at this point in the history

  10. Adjust existing test to fail

    @bdach
    bdach committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    81a0266 View commit details
    Browse the repository at this point in the history

  11. Add another failing tests covering recomputation of ranks

    @bdach
    bdach committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    3f31593 View commit details
    Browse the repository at this point in the history

  12. Move maximum statistics population to LegacyScoreDecoder

    @bdach
    bdach committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    aa8eee0 View commit details
    Browse the repository at this point in the history

  13. Use lazer accuracy & rank implementations across the board

    @bdach
    bdach committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    2958631 View commit details
    Browse the repository at this point in the history

  14. Unify legacy total score / accuracy / rank recomputation flows

    @bdach
    bdach committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    db48494 View commit details
    Browse the repository at this point in the history

  15. Remove superfluous recomputation of accuracy

    @bdach
    bdach committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    217cbf6 View commit details
    Browse the repository at this point in the history

  16. Remove legacy computation of accuracy & ranks

    @bdach
    bdach committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    cdd6e71 View commit details
    Browse the repository at this point in the history

  17. Update assertions to match expected behaviour

    @bdach
    bdach committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    d53fb5a View commit details
    Browse the repository at this point in the history

  18. Expand xmldoc

    @bdach
    bdach committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    24be6d9 View commit details
    Browse the repository at this point in the history

  19. Fix rank background processing not working (and not bumping score ver… 

    …sion)
    @bdach
    bdach committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    fdd499a View commit details
    Browse the repository at this point in the history

  20. Remove redundant assertion 

    It does look pretty dumb to be checking if something is `null` *after
calling an instance method on it*...
    @bdach
    bdach committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    4d253eb View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Apply more correct visual offset adjustment 

    Co-authored-by: Walavouchey <36758269+Walavouchey@users.noreply.github.com>
    @peppy @Walavouchey
    peppy and Walavouchey authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    0cf9067 View commit details
    Browse the repository at this point in the history

  2. Move transferal of LegacyTotalScore back to original spot 

    This subtle detail was messing with server-side score import flows.
Server-side, legacy total score will *already* be in `LegacyTotalScore`
from the start, and `TotalScore` will be zero until recomputed via
`StandardisedScoreMigrationTools.UpdateFromLegacy()` - so in that
context, attempting to move it across is incorrect.
    @bdach
    bdach committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    cb87d6c View commit details
    Browse the repository at this point in the history

  3. Remove outdated test 

    Non-legacy scores *are* subject to upgrades again - albeit it is *rank*
upgrades that they are subject to.
    @bdach
    bdach committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    0b5be3c View commit details
    Browse the repository at this point in the history

  4. Do not reprocess ranks for custom rulesets 

    Chances are that because we've broken rank API, it would utterly fail
for all custom rulesets anyhow.
    @bdach
    bdach committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    6c169e3 View commit details
    Browse the repository at this point in the history