Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update framework and adjust internal offsets for enhanced WASAPI support #26154

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

peppy
Copy link
Member

@peppy peppy commented Dec 27, 2023

@peppy peppy added blocked Don't merge this. next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! and removed size/S labels Dec 27, 2023
@EVAST9919
Copy link
Contributor

Can't replicate consistently, but a crash can happen when exiting a map to song select and immediately starting again.
And it can't be found in runtime log, got this only with ide attached.

Fatal error. System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt. Repeat 2 times: -------------------------------- at ManagedBass.Bass.FXSetPriority(Int32, Int32) -------------------------------- at osu.Framework.Audio.Mixing.Bass.BassAudioMixer+<>c__DisplayClass29_0.<onEffectsChanged>g__applyEffects|2(Int32, Int32) at osu.Framework.Audio.Mixing.Bass.BassAudioMixer+<>c__DisplayClass29_0.<onEffectsChanged>b__0() at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object) at System.Threading.Tasks.Task.ExecuteWithThreadLocal(System.Threading.Tasks.Task ByRef, System.Threading.Thread) at System.Threading.Tasks.ThreadPoolTaskScheduler.TryExecuteTaskInline(System.Threading.Tasks.Task, Boolean) at System.Threading.Tasks.TaskScheduler.TryRunInline(System.Threading.Tasks.Task, Boolean) at System.Threading.Tasks.Task.InternalRunSynchronously(System.Threading.Tasks.TaskScheduler, Boolean) at osu.Framework.Audio.AudioComponent.Update() at osu.Framework.Audio.AudioCollectionManager1[[System.__Canon, System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].UpdateChildren()
at osu.Framework.Audio.AudioComponent.Update()
at osu.Framework.Threading.AudioThread.onNewFrame()
at osu.Framework.Threading.GameThread.processFrame()
at osu.Framework.Threading.GameThread.RunSingleFrame()
at osu.Framework.Threading.GameThread.g__runWork|66_0()
at System.Threading.Thread+StartHelper.Callback(System.Object)
at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object)
at System.Threading.Thread.StartCallback()

`

1703654376.runtime.log

@peppy peppy marked this pull request as draft December 27, 2023 06:07
@bdach bdach removed the next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! label Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Don't merge this. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timing: Reassess "platform specific" audio offset
3 participants