Fix delete difficulty flow not actually deleting the difficulty from realm #24067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
commented
Jun 27, 2023
Comment on lines
+342
to
+343
| r.Remove(beatmapInfo.Metadata); | ||
| r.Remove(beatmapInfo); |
There was a problem hiding this comment.
Notably, this same thing already shows up in a few places:
osu/osu.Game/Beatmaps/BeatmapImporter.cs
Lines 103 to 104 in eb82bd3
osu/osu.Game/Database/RealmAccess.cs
Lines 347 to 348 in eb82bd3
but I'm not super sure two lines are worth splitting a helper for. Can do if that's considered better.
peppy
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As alluded to in #24060 (comment)
Mind you, as stated there, I don't really see how this can be related to the corruption users are seeing in #24034 et al., but it is one possible case wherein a beatmap could get detached from its set in realm.