Implement better logic for ApplyStateChange in skin editor
#23344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
requested changes
Apr 30, 2023
bdach
reviewed
Apr 30, 2023
Terochi
commented
Apr 30, 2023
Having `typedComponents` and `typeComponents` next to each other is asking for trouble.
Leaving only the ones that add anything useful and do not restate the code verbatim.
bdach
approved these changes
May 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves on the naive approach of
ISerialisableDrawableContainer.Reload()when traversing through history of changes to keep as many components as possible rather than creating new ones.Also fixes the first state when opening editor/changing layer not being saved.