Add modes text to groups tooltip #22340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you check the existing issue opened for this: #22331? The change is small but still was assigned to someone. It doesn't seem they were doing it right now, but just noting for future contributions. |
|
Oh. no i didn't check i only saw the issue on discord, didn't know someone was already working on this tho. Noted in case i contribute in the future. thanks |
3 tasks
bdach
approved these changes
Jan 22, 2023
There was a problem hiding this comment.
Cross-checked against web implementation, seems okay aside from a few code quality mishaps which I have fixed.
peppy
approved these changes
Jan 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to match it as close to website
Normal groups stay the same
Groups with 1 mode display as they should
It even works with 2 mode groups