Fix audio track not correctly advancing when changing between certain beatmaps #19678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoogipoo
previously approved these changes
Aug 10, 2022
smoogipoo
approved these changes
Aug 10, 2022
|
Hmm, just keep in mind those extensions are used outside of |
|
The namespace is also weird in that case >_> Let's leave it as it is and reconsider later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File comparison was not case-insensitive, causing
nullresults and equality as a result in the case where two beatmaps have their filename in their.osufiles specified using an incorrect case (null==null).I also went through a lot of other usages and fixed things up. There were a few other cases of incorrect lookups. Hopefully consolidating the method of lookup will help avoid this in the future...
Addresses #19667 (comment)