Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused RulesetStore from BeatmapManager constructor #19435

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

peppy
Copy link
Member

@peppy peppy commented Jul 28, 2022

Note that in test scenes which still have the RulesetStore, it is required to initialise the realm state when creating an isolated realm, so not removed.

@frenzibyte frenzibyte added type:code-quality realm deals with local realm database labels Jul 28, 2022
@smoogipoo smoogipoo merged commit 1da9830 into ppy:master Jul 28, 2022
@peppy peppy deleted the remove-beatmap-manager-ruleset-store branch July 31, 2022 07:00
This was referenced Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
realm deals with local realm database size/M type:code-quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants