-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure all mods are incompatible in both ways #19203
Conversation
…way mod incompatibility
Tests seem to be failing as it fails to find the instance of the mod it's comparing to (in some cases). The line which is causing it: https://github.com/ppy/osu/pull/19203/files#diff-38c0d7d7fdbeef4006389cbdab55fdb19f0c26c9152d500287ea7e8d91ed7765R39 Kinda unsure why, maybe someone else has an idea? |
Mods can declare incompatibility with other mods that may not necessarily be included in the same ruleset. For example, I'd suggest that you run the test locally with a debugger attached before pushing more commits to avoid unnecessary CI congestion. |
NoConflictingModAcronyms
test to ModValidity
, add test for two-way mod incompatibilities
Are you unable to debug this locally? It should be immediately apparent by checking what the fail cases are (this is a 100% failure). |
Also check all instances, rather than first.
As this seemed abandoned I fixed the remaining issue with the test. Looks to work as expected. |
After #19200 and #19201, it seemed appropriate to add an extra test that all mods are two-way incompatible.