Allow changing current star difficulty of a StarRatingDisplay
#12747
Conversation
| if (Current.Value == null) | ||
| background.FadeColour(Color4.SlateGray.Opacity(0.3f)); |
There was a problem hiding this comment.
In the case of metadata display (which this is intended for), wouldn't it make more sense to fade the rating out entirely than to show a faintly visible 0? That seems kind of confusing from a UX sense. It's data that's not ready to be displayed, so I don't think it should be. It almost looks like a bug.
There was a problem hiding this comment.
I was not sure about doing that at first, but now that I re-remember the existence of AutoSizeDuration, can make something out of it.
There was a problem hiding this comment.
I'd probably go for a - when data is unavailable. Showing nothing at all doesn't seem correct.
There was a problem hiding this comment.
A plain - sprite text placeholder on the metadata display itself? or inside the StarRatingDisplay in here?
There was a problem hiding this comment.
I'm not really sure, would have to see how things look. This might be a bit complicated based on how it's currently split up.
There was a problem hiding this comment.
There's no test covering this state.
There was a problem hiding this comment.
It's kind of already covered as it starts with null difficulty, but I'll add an explicit test step.
There was a problem hiding this comment.
In the case of metadata display (which this is intended for), wouldn't it make more sense to fade the rating out entirely than to show a faintly visible 0? That seems kind of confusing from a UX sense. It's data that's not ready to be displayed, so I don't think it should be. It almost looks like a bug.
I've tried this approach + some fancy transforms and it looks to be good enough as a simple alternative way for the time being until the whole screen gets redesigned:
As the component no longer has any transition transforms applied.
Required for #12717 as the star difficulty is calculated asynchronously and the current rulesets or mods may change after the player loader metadata display has been loaded. (e.g.
ReplayPlayerLoader.OnEntering)As a UX update for
StarRatingDisplaynow that it can be changed, I've added a simple colour fading on the background, I was also going to add a simple rolling transition between old and new star difficulties, but it appears that the design isn't really compatible with such change (font right-aligned and looks unpleasant with fixed-width on), so I've reverted that.