-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Floating Fruits" mod #12461
Add "Floating Fruits" mod #12461
Conversation
{ | ||
player.DrawableRuleset.Anchor = Anchor.Centre; | ||
player.DrawableRuleset.Origin = Anchor.Centre; | ||
player.DrawableRuleset.Scale = new osuTK.Vector2(1, -1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implementation, however simple, causes the catcher-following combo counter to appear upside down on legacy skins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how much of an issue this one is to be honest. The "Barrel Roll" mod does the same for SPM counter and judgements, for instance. Maybe adds to the style?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It bothers me less in barrel roll, possibly because in that case motion is constant and continuous. It looks weirder here where everything is statically flipped.
I guess if you think it's fine I'm not going to insist on having this fixed, just figured it'd be something people will bring up. Could also be left as a follow up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That said I do think fixing this shouldn't be too hard if going the minimal effort way (get combo counter via ChildrenOfType()
, check if it's legacy, if it is, flip Y axis - the playfield flip will cancel out the combo counter flip and it'll be upright again).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally trying to keep use of ChidrenOfType
to tests only (i think we have so far?) so if we do decide to account for flipping it'd need to be exposed in a better way.
As an aside mania has a similar thing in upscroll/downscroll, albeit it is a game-level setting rather than a separate mod. Unsure whether this should follow that convention. |
I think it would fit better as a mod. When googling for "osu!catch upside down" and similar queries everything I can find is a challenge thread from 2016 about it, so it doesn't seem like any catch players actually are playing upside down as their play style, unlike mania that has a lot of upscroll players & discussions about it. More opinions on this would probably be great (?), but I think upscrolling in catch would just be something people do for fun once in a while, and not have as their main play style |
Not sold on the naming but I think this is fine for an initial pass. Tend to agree that the combo counter should be accounted for in a future change. |
For experimental mods like this I'm not sure what the process should be for |
An osu!catch-specific mod, makes the fruits float upwards instead of falling downwards. Compatible with all current mods.
One potential improvement could be to have the mod move the score bar as it can be a bit disturbing while playing, however it's just a minor inconvenience that can be solved by hiding the HUD during gameplay (ctrl+tab).
Video of the mod with HUD on / off:
floating.fruits.mp4