Fix placement blueprints not being correctly removed after a rolled back placement #12437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is hard to write a test for on its own since nothing actually uses the non-commit path apart from the
BlueprintContaineritself (which handles correctly as a result), but will be used for upcoming work to fix #10959.The issue is that the
.Expirecall is only triggered if theremovePlacement()function is run, but asPlacementActivewas returned to afalsestate on commit-revert, theComposeBlueprintContaineris unable to know whether placement was never-started or has finished (and been reverted). I considered adding another entry in the enum forRolledBackor similar, but probably not worth doing so until we need it.Before (can't exit placement):
After: